[PATCH] D133078: [X86][NFC] Refine load/store reg to StackSlot for extensibility

[Xiang Zhang via Phabricator via llvm-commits]

xiangzhangllvm added inline comments.


================
Comment at: llvm/lib/Target/X86/X86InstrInfo.cpp:3553
 
+static unsigned getLoadStoreOpcodeForFP16s(bool load, const X86Subtarget &STI) {
+  if (STI.hasFP16())
----------------
craig.topper wrote:
> Capitalize `load` I know it was wrong before, but should we keep propagating it?
OK, let all "load" to Load. thank you!


================
Comment at: llvm/lib/Target/X86/X86InstrInfo.cpp:3852
 
+static bool SpecialOpcode(unsigned Opc) {
+  switch (Opc) {
----------------
craig.topper wrote:
> function names should be lower case and start with a verb. "SpecialOpcode" is also vague. Can it be more specific?
let me rename it to isTILEReg, in fact, at first I consider it may has other specific reg (not only tile) in the futher, so I name it "Special".


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133078/new/

https://reviews.llvm.org/D133078