[PATCH] D132935: [PHITranslateAddr] Require dominance when searching for translated address (PR57025)

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

In D132935#3764102 <https://reviews.llvm.org/D132935#3764102>, @fhahn wrote:

> Thanks for the fix, LGTM as well.
>
>> , if we have a pointer value that does not require any translation, then it is fine to continue using that value in the predecessor, because the context is still correct for the original query.
>
> Could we just check for that case in translation and then always set `MustDominate` to `true`?

I don't think so, in that we do need the current strict MustDominate behavior when we check whether the translated value needs to be materialized in the predecessor during PRE.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132935/new/

https://reviews.llvm.org/D132935