[PATCH] D132935: [PHITranslateAddr] Require dominance when searching for translated address (PR57025)

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Sep 1 08:02:12 PDT 2022


fhahn added a comment.

Thanks for the fix, LGTM as well.

> , if we have a pointer value that does not require any translation, then it is fine to continue using that value in the predecessor, because the context is still correct for the original query.

Could we just check for that case in translation and then always set `MustDominate` to `true`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132935/new/

https://reviews.llvm.org/D132935



More information about the llvm-commits mailing list