[PATCH] D129352: [CodeGen] Limit building time for CodeGenPrepare

[LuoYuanke via Phabricator via llvm-commits]

LuoYuanke added a comment.

In D129352#3760394 <https://reviews.llvm.org/D129352#3760394>, @nikic wrote:

> In D129352#3760376 <https://reviews.llvm.org/D129352#3760376>, @LuoYuanke wrote:
>
>> In D129352#3760370 <https://reviews.llvm.org/D129352#3760370>, @nikic wrote:
>>
>>> Do we need the IsHugeFunc flag? Can't we use the worklist approach unconditionally? This is what we usually do. Limiting it to IsHugeFunc means that it received essentially zero testing.
>>
>> I think `IsHugeFunc` can help avoid runtime performance regression on real application. We can specify `IsHugeFunc` as 0 in test case and then shrink the default `IsHugeFunc` size after this patch. Finally we can remove `IsHugeFunc`.
>
> Is there any reason to expect this to materially affect runtime performance?

I think it is more conservative and we can move on by tuning the `IsHugeFunc` size step by step. Otherwise we may revert the whole patch if someone report regression after the patch landing for a long while. Ideally, I agree to remove `IsHugeFunc`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129352/new/

https://reviews.llvm.org/D129352