[PATCH] D129352: [CodeGen] Limit building time for CodeGenPrepare
Nikita Popov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Aug 31 01:16:21 PDT 2022
nikic added a reviewer: spatel.
nikic added a comment.
In D129352#3760426 <https://reviews.llvm.org/D129352#3760426>, @LuoYuanke wrote:
> I think it is more conservative and we can move on by tuning the `IsHugeFunc` size step by step. Otherwise we may revert the whole patch if someone report regression after the patch landing for a long while. Ideally, I agree to remove `IsHugeFunc`.
IMHO, if it causes issues we want to find out early and revert the whole patch, rather than just exposing these issues in very rare circumstances.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D129352/new/
https://reviews.llvm.org/D129352
More information about the llvm-commits
mailing list