[PATCH] D129352: [CodeGen] Limit building time for CodeGenPrepare

Wed Aug 31 00:22:18 PDT 2022

nikic added a comment.

In D129352#3760376 <https://reviews.llvm.org/D129352#3760376>, @LuoYuanke wrote:

> In D129352#3760370 <https://reviews.llvm.org/D129352#3760370>, @nikic wrote:
>
>> Do we need the IsHugeFunc flag? Can't we use the worklist approach unconditionally? This is what we usually do. Limiting it to IsHugeFunc means that it received essentially zero testing.
>
> I think `IsHugeFunc` can help avoid runtime performance regression on real application. We can specify `IsHugeFunc` as 0 in test case and then shrink the default `IsHugeFunc` size after this patch. Finally we can remove `IsHugeFunc`.

Is there any reason to expect this to materially affect runtime performance?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129352/new/

https://reviews.llvm.org/D129352