[PATCH] D129352: [CodeGen] Limit building time for CodeGenPrepare

LuoYuanke via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 31 00:16:20 PDT 2022


LuoYuanke added a comment.

In D129352#3760370 <https://reviews.llvm.org/D129352#3760370>, @nikic wrote:

> Do we need the IsHugeFunc flag? Can't we use the worklist approach unconditionally? This is what we usually do. Limiting it to IsHugeFunc means that it received essentially zero testing.

I think `IsHugeFunc` can help avoid runtime performance regression on real application. We can specify `IsHugeFunc` as 0 in test case and then shrink the default `IsHugeFunc` size after this patch. Finally we can remove `IsHugeFunc`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129352/new/

https://reviews.llvm.org/D129352



More information about the llvm-commits mailing list