[PATCH] D119507: [MLGO] Use TFLite in 'development mode'

Petr Hosek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 23 23:58:32 PDT 2022


phosek added inline comments.


================
Comment at: llvm/CMakeLists.txt:942
+  set(LLVM_PROTOBUF_OUT_DIR ${CMAKE_LIBRARY_OUTPUT_DIRECTORY}/protobuf_gen)
+  include_directories(${LLVM_PROTOBUF_OUT_DIR})
+elseif (TENSORFLOW_C_LIB_PATH)
----------------
Could this be scoped more narrowly? That is, only add the include directory to the targets that actually need it with `target_include_directories`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119507/new/

https://reviews.llvm.org/D119507



More information about the llvm-commits mailing list