[PATCH] D119507: [MLGO] Use TFLite in 'development mode'

[Mircea Trofin via Phabricator via llvm-commits]

mtrofin marked an inline comment as done.
mtrofin added inline comments.


================
Comment at: llvm/CMakeLists.txt:942
+  set(LLVM_PROTOBUF_OUT_DIR ${CMAKE_LIBRARY_OUTPUT_DIRECTORY}/protobuf_gen)
+  include_directories(${LLVM_PROTOBUF_OUT_DIR})
+elseif (TENSORFLOW_C_LIB_PATH)
----------------
phosek wrote:
> Could this be scoped more narrowly? That is, only add the include directory to the targets that actually need it with `target_include_directories`.
I tried, it seems quite complicated - and we want to subsequently get rid of the protobuf dependency anyway, so wonder if it's worth the trouble for the interim


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119507/new/

https://reviews.llvm.org/D119507