[PATCH] D132376: [BOLT][AArch64] Handle external references to the middle of Constant Islands

[Denis via Phabricator via llvm-commits]

treapster added inline comments.


================
Comment at: bolt/lib/Core/BinaryContext.cpp:402
+
     if (IslandIter != AddressToConstantIslandMap.end()) {
       if (MCSymbol *IslandSym =
----------------
yota9 wrote:
> I assume we need to add extra check that we're still in bounds of the function. E.g. for the case when IslandIter was originally eq to AddressToConstantIslandMap.end() and we've decremented the iterator.
getOrCreateIslandAccess (which is called by     getOrCreateProxyIslandAccess) returns nullptr if !isInConstantIsland(Address))


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132376/new/

https://reviews.llvm.org/D132376