[PATCH] D132376: [BOLT][AArch64] Handle external references to the middle of Constant Islands

[Vladislav Khmelevsky via Phabricator via llvm-commits]

yota9 requested changes to this revision.
yota9 added inline comments.
This revision now requires changes to proceed.


================
Comment at: bolt/lib/Core/BinaryContext.cpp:399
+      else
+        --IslandIter;
+    }
----------------



================
Comment at: bolt/lib/Core/BinaryContext.cpp:402
+
     if (IslandIter != AddressToConstantIslandMap.end()) {
       if (MCSymbol *IslandSym =
----------------
I assume we need to add extra check that we're still in bounds of the function. E.g. for the case when IslandIter was originally eq to AddressToConstantIslandMap.end() and we've decremented the iterator.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132376/new/

https://reviews.llvm.org/D132376