[PATCH] D132376: [BOLT][AArch64] Handle external references to the middle of Constant Islands

Denis via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 23 15:05:32 PDT 2022


treapster added inline comments.


================
Comment at: bolt/lib/Core/BinaryContext.cpp:399
+      else
+        --IslandIter;
+    }
----------------
yota9 wrote:
> 
It should be  `IslandIter = std::prev(IslandIter)` or `std::advance(IslandIter, -1)`, but i think there's no need to be verbose here. Why not leave it as a decrement?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132376/new/

https://reviews.llvm.org/D132376



More information about the llvm-commits mailing list