[PATCH] D132482: RISCV: permit unaligned nop-slide padding emission

Saleem Abdulrasool via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 23 12:45:49 PDT 2022


compnerd marked 4 inline comments as done.
compnerd added inline comments.


================
Comment at: llvm/lib/Target/RISCV/MCTargetDesc/RISCVAsmBackend.cpp:363
+      OS.write("\x01\0", 2);
+
+  // If the count is not 4-byte aligned (or 2-byte under the C extensions), we
----------------
jrtc27 wrote:
> Making this a loop is a bit odd when we know it's always executing 0 or 1 times
It seems nicer and feels more in line with the non-C version.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132482/new/

https://reviews.llvm.org/D132482



More information about the llvm-commits mailing list