[PATCH] D130120: [2/3] [LLD] [COFF] Add support for a new, mingw specific embedded directive -exclude-symbols:

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added inline comments.


================
Comment at: lld/COFF/Driver.h:55-57
   std::vector<StringRef> exports;
   std::vector<StringRef> includes;
+  std::vector<StringRef> excludes;
----------------
rnk wrote:
> It's not great that "excludes" is literally the opposite of "includes" when it is meant to be the opposite of exports, but of course we should use the name that ld.bfd went with.
Yeah - also the directive name `exclude-symbols` feels a bit odd to have as plural, but I preferred to keep it matching the the existing command line option (existing in ld.bfd).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130120/new/

https://reviews.llvm.org/D130120