[PATCH] D130120: [2/3] [LLD] [COFF] Add support for a new, mingw specific embedded directive -exclude-symbols:

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 9 10:27:19 PDT 2022


rnk accepted this revision.
rnk added a comment.

I think it's a reasonable feature.



================
Comment at: lld/COFF/Driver.h:55-57
   std::vector<StringRef> exports;
   std::vector<StringRef> includes;
+  std::vector<StringRef> excludes;
----------------
It's not great that "excludes" is literally the opposite of "includes" when it is meant to be the opposite of exports, but of course we should use the name that ld.bfd went with.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130120/new/

https://reviews.llvm.org/D130120



More information about the llvm-commits mailing list