[PATCH] D130120: [2/3] [LLD] [COFF] Add support for a new, mingw specific embedded directive -exclude-symbols:

[Fangrui Song via Phabricator via llvm-commits]

MaskRay accepted this revision.
MaskRay added inline comments.
Herald added a subscriber: StephenFan.


================
Comment at: lld/COFF/Driver.h:164
   llvm::StringSet<> directivesExports;
+  llvm::StringSet<> excludedSymbols;
 
----------------
Prefer llvm::DenseSet<StringRef>.

`StringSet<>` stores strings and is therefore more expensive. The values are backed by `saver()`.


================
Comment at: lld/test/COFF/exclude-symbols-embedded.s:5
+// RUN: lld-link -lldmingw -dll -out:%t.dll %t.o -noentry
+// RUN: llvm-readobj --coff-exports %t.dll | grep Name: | FileCheck %s
+
----------------
See my comment in another patch that grep Name: can be removed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130120/new/

https://reviews.llvm.org/D130120