[PATCH] D130233: [LoopLoadElim] Add stores with matching sizes as load-store candidates

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: llvm/test/Transforms/EarlyCSE/vector_bitcasting_be.ll:1
+; RUN: opt --opaque-pointers -O3 -S < %s | FileCheck %s
+
----------------
mgabka wrote:
> I think a good idea would be to run directly only the passes you actually want to test instead of using O3
The test should also be in the LoopLoadElim directory rather than EarlyCSE, and use update_test_checks.py.


================
Comment at: llvm/test/Transforms/LoopLoadElim/type-mismatch.ll:97
+; pointers; We could potentially do this in future but in IR pointers are
+; considered to have a size of 0.
+; CHECK-LABEL: @f3(
----------------
Eh, while that happens to work out okay here, please do replace all your getPrimitiveSizeInBits() calls with getTypeSizeInBits() on DataLayout.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130233/new/

https://reviews.llvm.org/D130233