[PATCH] D130233: [LoopLoadElim] Add stores with matching sizes as load-store candidates

[mgabka via Phabricator via llvm-commits]

mgabka added inline comments.


================
Comment at: llvm/test/Transforms/EarlyCSE/vector_bitcasting_be.ll:1
+; RUN: opt --opaque-pointers -O3 -S < %s | FileCheck %s
+
----------------
I think a good idea would be to run directly only the passes you actually want to test instead of using O3


================
Comment at: llvm/test/Transforms/EarlyCSE/vector_bitcasting_be.ll:9
+
+  %val1 = alloca <1 x i32>, align 4
+  store i32 3, ptr %val1, align 4
----------------
can you just pass val1 as argument to this function and remove the alloca?

same request about f2 function and the other file with tests that you added.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130233/new/

https://reviews.llvm.org/D130233