[PATCH] D130233: [LoopLoadElim] Add stores with matching sizes as load-store candidates

[David Sherwood via Phabricator via llvm-commits]

david-arm added inline comments.


================
Comment at: llvm/test/Transforms/LoopLoadElim/type-mismatch.ll:100
+; CHECK-NOT: store_forwarded
+define void @f3(i64* noalias %A, i64* noalias %B, i64* noalias %C, i64 %N) {
+
----------------
Hi @jolanta.jensen, I think it would be good if you could pre-commit these tests separately in a different patch, then rebase your changes on top. That way we can see the change in output and it makes it easier to see what effect the patch has.

Also, in the same pre-commit patch it would be good if you could generate the CHECK lines with the update_test_checks.py script because I find it a bit hard to see what's going on with partial CHECK lines, mixed between lines of IR.

Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130233/new/

https://reviews.llvm.org/D130233