[PATCH] D130233: [LoopLoadElim] Add stores with matching sizes as load-store candidates

Jolanta Jensen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 8 06:39:06 PDT 2022


jolanta.jensen added a comment.

In D130233#3667850 <https://reviews.llvm.org/D130233#3667850>, @nikic wrote:

> Not all types are bitcastable. Please add tests where the load/store are pointer and integer (in which case you need inttoptr or ptrtoint -- and watch out for non-integral address spaces) and one where an aggregate is involved (cannot be bitcast at all).

@nikic , Thank you for a quick review and apologies for the delay addressing them. I'm now guarding against non-valid bitcasts. For inttoptr or ptrtoint request, f3 in type-mismatch-opaque-ptr.ll has such a case. Do you want more extensive testing than that?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130233/new/

https://reviews.llvm.org/D130233



More information about the llvm-commits mailing list