[PATCH] D130677: [AMDGPU] Fix DGEMM hazard for GFX90a

Vang Thao via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 28 12:16:33 PDT 2022


vangthao added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPU.td:282
 
+def FeatureDGEMMVALUWriteMemOpBug : SubtargetFeature<"dgemm-valu-write-mem-op-bug",
+  "HasDGEMMVALUWriteMemOpBug",
----------------
rampitec wrote:
> I do not believe it deserves a feature bit. These bits are limited.
Is there a way to check for gfx90a only? I thought about `hasGFX90AInsts()` but this also includes gfx940. We could exclude gfx940 with `!hasGFX940Insts()` but that does not seem like a clean way of doing so.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130677/new/

https://reviews.llvm.org/D130677



More information about the llvm-commits mailing list