[PATCH] D130560: [RISCV] Handle register spill in branch relaxation

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 26 11:22:40 PDT 2022


efriedma added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfo.cpp:999
+    int FrameIndex = RVMFI->getBranchRelaxationScratchFrameIndex();
+    assert(FrameIndex != -1 && "underestimated function size");
+
----------------
You probably want to report_fatal_error if you don't have a frame index, so you get an error in release builds if the heuristic breaks somehow.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130560/new/

https://reviews.llvm.org/D130560



More information about the llvm-commits mailing list