[PATCH] D130560: [RISCV] Handle register spill in branch relaxation

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 26 11:30:29 PDT 2022


efriedma added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVFrameLowering.cpp:1007
+    for (auto &MI : MBB)
+      FnSize += TII.getInstSizeInBytes(MI);
+
----------------
You might want to consider using a more conservative estimate for conditional branches, since they can be relaxed to unconditional branches.  (I know we don't do this in the ARM function you borrowed this from, but probably we should.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130560/new/

https://reviews.llvm.org/D130560



More information about the llvm-commits mailing list