[PATCH] D130316: [SelectionDAG] make INLINEASM_BR use MachineBasicBlocks instead of BlockAddresses
    Nikita Popov via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Sat Jul 23 03:30:36 PDT 2022
    
    
  
nikic added a comment.
I like the change, but I'm not familiar enough with the backend to fully understand the implications. The main thing I'd worry about is that more places that currently check hasAddressTaken() would also need to check isInlineAsmBrIndirectTarget(). E.g. I see more calls to the method in IfConversion. (Would it make sense to stop using blockaddresses, but still mark the MBBs are address-taken?)
Repository:
  rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130316/new/
https://reviews.llvm.org/D130316
    
    
More information about the llvm-commits
mailing list