[PATCH] D130316: [SelectionDAG] make INLINEASM_BR use MachineBasicBlocks instead of BlockAddresses

Fri Jul 22 15:38:45 PDT 2022

barannikov88 added inline comments.

================
Comment at: llvm/test/CodeGen/X86/inline-asm-pic.ll:34
 ; CHECK-NEXT:    retl
 ; CHECK-NEXT:  Ltmp0: ## Block address taken
 ; CHECK-NEXT:  LBB1_1: ## %overflow
----------------
nickdesaulniers wrote:
> barannikov88 wrote:
> > The one here remains.
> This is expected. You'll notice that it's address is taken by the `blockaddress` constant in `@y` (Line 57).
> 
> My change stops using `blockaddress` for callbr.  It doesn't remove `blockaddress` from the language; test `@y` is testing the "address of a label" as an input to the inline asm, which is distinct from the label list used in asm goto.
> 
> That said, thanks for triple checking!
Nope, line 57 is a different test.
Anyway, this was just an observation and not a suggestion to look into this specific case. Most parasitic labels are gone, so this is probably something X86-specific, which I believe is out of scope of this patch series.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130316/new/

https://reviews.llvm.org/D130316