[PATCH] D129764: [ORC][COFF] Properly set weak flag to COMDAT symbols.

[Lang Hames via Phabricator via llvm-commits]

lhames accepted this revision.
lhames added a comment.
This revision is now accepted and ready to land.

Otherwise LGTM. Thanks @sunho!



================
Comment at: llvm/test/ExecutionEngine/JITLink/X86/COFF_strong_duplicate.s:9
+# RUN: -slab-allocate 100Kb -slab-address 0xfff00000 -slab-page-size 4096 \
+# RUN: -show-graph -noexec 2>&1 | FileCheck %s
+#
----------------
sunho wrote:
> sgraenitz wrote:
> > Can we use `# RUN: not llvm-jitlink ...` to check that we get a non-zero exit code instead of XFAILing the test? My impression was that XFAIL should be used specifically to mark bugs and todos.
> I didn't know about not when I wrote this. Thanks for pointing out!
Even better, can we check for the text of the error to verify that it failed for the expected reason? (And likewise in the other testcase, if possible)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129764/new/

https://reviews.llvm.org/D129764