[PATCH] D129764: [ORC][COFF] Properly set weak flag to COMDAT symbols.

Sunho Kim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 18 19:43:23 PDT 2022


sunho updated this revision to Diff 445680.
sunho added a comment.

Address comments, strong + weak test will be corrected in follow up patch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129764/new/

https://reviews.llvm.org/D129764

Files:
  llvm/lib/ExecutionEngine/Orc/ObjectFileInterface.cpp
  llvm/test/ExecutionEngine/JITLink/X86/COFF_comdat_weak_duplicate.s
  llvm/test/ExecutionEngine/JITLink/X86/COFF_comdat_weak_plus_strong.s
  llvm/test/ExecutionEngine/JITLink/X86/COFF_strong_duplicate.s
  llvm/test/ExecutionEngine/JITLink/X86/Inputs/COFF_comdat_weak_def.yaml
  llvm/test/ExecutionEngine/JITLink/X86/Inputs/COFF_strong_def.yaml

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D129764.445680.patch
Type: text/x-patch
Size: 8317 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220719/f984dc9c/attachment.bin>


More information about the llvm-commits mailing list