[PATCH] D129721: [JITLink][COFF] Handle out-of-order COMDAT second symbol.

[Lang Hames via Phabricator via llvm-commits]

lhames accepted this revision.
lhames added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: llvm/lib/ExecutionEngine/JITLink/COFFLinkGraphBuilder.cpp:193
   SymbolSets.resize(Obj.getNumberOfSections() + 1);
+  PendingComdatExports.resize(Obj.getNumberOfSections() + 1);
   GraphSymbols.resize(Obj.getNumberOfSymbols());
----------------
What's the maximum number of sections in a COFF object? Could this get large for pathological objects? (In which case a `DenseMap<SectionIndex, ComdatExportRequest>` might be better?)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129721/new/

https://reviews.llvm.org/D129721