[PATCH] D129721: [JITLink][COFF] Handle out-of-order COMDAT second symbol.

Sunho Kim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 19 06:35:39 PDT 2022


sunho added inline comments.


================
Comment at: llvm/lib/ExecutionEngine/JITLink/COFFLinkGraphBuilder.cpp:523
   });
   PendingComdatExport = None;
   return Target;
----------------
sunho wrote:
> sgraenitz wrote:
> > Shouldn't this assign to `PendingComdatExports[Symbol.getSectionNumber()]` now?
> good catch! it miraclely built succesfully as variable with the same name was introduced.
For clearness, I changed PendinComdatExport to reference so that original node will be just set None.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129721/new/

https://reviews.llvm.org/D129721



More information about the llvm-commits mailing list