[PATCH] D123496: [RISCV] Add Stackmap/Statepoint/Patchpoint support without targets

[Sacha Coppey via Phabricator via llvm-commits]

Zeavee added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVAsmPrinter.cpp:101
+  SM.recordStackMap(*MILabel, MI);
+  assert(NumNOPBytes % 4 == 0 && "Invalid number of NOP bytes requested!");
+
----------------
jrtc27 wrote:
> Is it still invalid with RVC? You can have 2-byte NOPs there...
I indeed missed the C_NOP. Should we add one when NumNOPBytes % 4 == 2 then, because emitNops only emits 4 bytes NOPs?


================
Comment at: llvm/test/CodeGen/RISCV/rv64-patchpoint.ll:3
+; RUN: llc -mtriple=riscv64 -debug-entry-values -enable-misched=0                             < %s | FileCheck %s
+; RUN: llc -mtriple=riscv64 -debug-entry-values -enable-misched=0 -fast-isel -fast-isel-abort=1 < %s | FileCheck %s
+
----------------
jrtc27 wrote:
> RISCV doesn't have FastISel support, it is identical to the previous line
I will remove it then.


================
Comment at: llvm/test/CodeGen/RISCV/stackmap-frame-setup.ll:16-18
+;; NOTE: These prefixes are unused and the list is autogenerated. Do not add tests below this line:
+; FAST-ISEL: {{.*}}
+; ISEL: {{.*}}
----------------
jrtc27 wrote:
> Huh?
This was added by update_llc_test_checks.py.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123496/new/

https://reviews.llvm.org/D123496