[PATCH] D129268: Legalise patchpoint arguments.

[Matt Arsenault via Phabricator via llvm-commits]

arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

LGTM with nits



================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp:5548
+  ConstantSDNode *CN = dyn_cast<ConstantSDNode>(Op);
+  if (CN == nullptr) {
+    return SDValue();
----------------
!CN


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp:5550
+    return SDValue();
+  }
+
----------------
Don't need braces


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp:5587-5590
+  ConstantSDNode *CN = dyn_cast<ConstantSDNode>(Op);
+  if (CN == nullptr) {
+    return SDValue();
+  }
----------------
Ditto


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129268/new/

https://reviews.llvm.org/D129268