[PATCH] D129268: Legalise patchpoint arguments.

[Edd Barrett via Phabricator via llvm-commits]

vext01 added a comment.

This should be ready now.



================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:9373-9374
+
+    // Things on the stack are pointer-typed, meaning that they are already
+    // legal and can be emitted directly to target nodes.
+    if (FrameIndexSDNode *FI = dyn_cast<FrameIndexSDNode>(Op)) {
----------------
arsenm wrote:
> This comment is kind of a lie. Pointer typed doesn't imply legality but I guess it doesn't really matter
I see what you are saying, although the pointer itself should be legal (even if the pointee isn't).

I agree that it doesn't hugely matter.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129268/new/

https://reviews.llvm.org/D129268