[PATCH] D129450: [RISCV] Move the custom isel for (add X, imm) into SelectAddrRegImm.

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 11 07:35:56 PDT 2022

Previous message: [PATCH] D129268: Legalise patchpoint arguments.
Next message: [PATCH] D129450: [RISCV] Move the custom isel for (add X, imm) into SelectAddrRegImm.
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

asb accepted this revision.
asb added a comment.

LGTM, but could you please add a brief comment before `isWorthFoldingAdd` to provide some narrative explanation of why this transformation is done.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129450/new/

https://reviews.llvm.org/D129450

Previous message: [PATCH] D129268: Legalise patchpoint arguments.
Next message: [PATCH] D129450: [RISCV] Move the custom isel for (add X, imm) into SelectAddrRegImm.
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the llvm-commits mailing list