[PATCH] D129774: [llvm][AArch64] Add missing FPCR, H and B registers to Codeview mapping

David Spickett via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 14 07:08:41 PDT 2022


DavidSpickett created this revision.
Herald added subscribers: hiraditya, kristof.beyls.
Herald added a project: All.
DavidSpickett requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Fixes https://github.com/llvm/llvm-project/issues/56484

H registers are 16 bit views of AArch64's Neon registers and
B are the 8 bit views.

msvc does not support 16 bit float (some mention in DirectX but I
couldn't find a way to get to it) so for lack of a better reference
I'm using:
https://github.com/MicrosoftEdge/JsDbg/blob/85c9b41b33bb8f3496dbe400d912c32bb7cc496b/server/references/dia/include/cvconst.h
(the other microsoft-pdb repo is no longer up to date)

Luckily clang does support fp16 so a test is added for that.

There is no 8 bit float type so I had to get creative with the
test case. We're not testing for correct debug info here just
that we can select the B register and not crash in the process.

For FPCR it's never going to be passed as an argument so I've
not added a test for it. It is included to keep our list looking
the same as the reference.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D129774

Files:
  llvm/include/llvm/DebugInfo/CodeView/CodeViewRegisters.def
  llvm/lib/Target/AArch64/MCTargetDesc/AArch64MCTargetDesc.cpp
  llvm/test/DebugInfo/COFF/AArch64/codeview-b-register.mir
  llvm/test/DebugInfo/COFF/AArch64/codeview-h-register.mir

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D129774.444650.patch
Type: text/x-patch
Size: 13355 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220714/65ea9d74/attachment.bin>


More information about the llvm-commits mailing list