[PATCH] D129773: [NVPTX][NFC] Simplify printing initialization of aggregates

Igor Kudrin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 15 09:26:04 PDT 2022


ikudrin updated this revision to Diff 445013.
ikudrin marked an inline comment as done.
ikudrin added a comment.

Thanks!

- Rename `printInBytes()` -> `printBytes`()`, `printInWords()` -> `printWords()`
- Remove an `raw_ostream` argument in the constructor of AggBuffer; pass the stream directly to `printBytes()`/`printWords()`
- Extract `printSymbol()` in this patch to further simplify D127504 <https://reviews.llvm.org/D127504>
- `isNonGenericPointer` -> `isGenericPointer`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129773/new/

https://reviews.llvm.org/D129773

Files:
  llvm/lib/Target/NVPTX/NVPTXAsmPrinter.cpp
  llvm/lib/Target/NVPTX/NVPTXAsmPrinter.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D129773.445013.patch
Type: text/x-patch
Size: 7292 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220715/0f549285/attachment.bin>


More information about the llvm-commits mailing list