[PATCH] D86539: [Debuginfo][llvm-dwarfutil] llvm-dwarfutil dsymutil-like tool for ELF.

Fri Jul 8 16:08:30 PDT 2022

MaskRay added a comment.

In D86539#3640104 <https://reviews.llvm.org/D86539#3640104>, @clayborg wrote:

> In D86539#3639533 <https://reviews.llvm.org/D86539#3639533>, @avl wrote:
>
>> @clayborg @jhenderson  Thank you and all for the review!
>>
>> In D86539#3637202 <https://reviews.llvm.org/D86539#3637202>, @clayborg wrote:
>>
>>> What will this tool do if the "--odr-deduplication" and "--garbage-collection" are not specified?
>>
>> The default state for --garbage-collection is enabled.
>> The default state for --odr-deduplication is enabled.
>
> Ah, these take a value like "--garbage-collection=0" or "--garbage-collection=1"? Then this is ok.

For user-facing utilities, the convention is `--(no-)?foobar`. It seems that `--(no-)?garbage-collection` is implemented in this patch, which is nice.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86539/new/

https://reviews.llvm.org/D86539