[PATCH] D86539: [Debuginfo][llvm-dwarfutil] llvm-dwarfutil dsymutil-like tool for ELF.

[Greg Clayton via Phabricator via llvm-commits]

clayborg added a comment.

In D86539#3639533 <https://reviews.llvm.org/D86539#3639533>, @avl wrote:

> @clayborg @jhenderson  Thank you and all for the review!
>
> In D86539#3637202 <https://reviews.llvm.org/D86539#3637202>, @clayborg wrote:
>
>> What will this tool do if the "--odr-deduplication" and "--garbage-collection" are not specified?
>
> The default state for --garbage-collection is enabled.
> The default state for --odr-deduplication is enabled.

Ah, these take a value like "--garbage-collection=0" or "--garbage-collection=1"? Then this is ok.

> Thus if above options are not specified the tool would enable them.
>
>> One other quick suggestion for the "bfd" value for the "--tombstone" option, should we state that the value is zero? Or maybe even change "bfd" to "zero"?
>
> Following is the description for bfd value from documentation section:
>
>   - `bfd`: zero for all addresses and [1,1] for DWARF v4 (or less) address ranges.
>
> Do you think this description should be changed?

We currently have:

  =bfd                  -   BFD default value.
  =maxpc             -   Max PC values(-1/-2).

I was suggesting just adding something like:

  =bfd                  -   BFD default value (0).
  =maxpc             -   Max PC values (-1/-2).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86539/new/

https://reviews.llvm.org/D86539