[PATCH] D129263: Windows packaging script. Check administrator permissions and/or 7-Zip version.

Hans Wennborg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 8 02:13:41 PDT 2022


hans accepted this revision.
hans added a comment.

lgtm, thanks!



================
Comment at: llvm/utils/release/build_llvm_release.bat:21
+
+REM Check for correct 7-zip version and/or administrator permissions.
+for /f "delims=" %%i in ('7z.exe ^| findstr /r "2[1-9]"') do set version=%%i
----------------
Nit: maybe drop "correct" since they're all correct. How about just "Check 7-zip version and/or administrator permissions."


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129263/new/

https://reviews.llvm.org/D129263



More information about the llvm-commits mailing list