[PATCH] D129263: Windows packaging script. Check administrator permissions and/or 7-Zip version.

[Tobias Hieta via Phabricator via llvm-commits]

thieta accepted this revision.
thieta added a comment.
This revision is now accepted and ready to land.

LGTM - maybe a small comment, but won't block on that.



================
Comment at: llvm/utils/release/build_llvm_release.bat:24
+if not "%version%"=="" (
+  if not exist %SYSTEMROOT%\SYSTEM32\WDI\LOGFILES (
+    echo.
----------------
Took me a while to understand this check - I am guessing you would only have permissions to see it if you are admin? Maybe that should be a comment to explain. There is no better way to test for admin rights in bat?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129263/new/

https://reviews.llvm.org/D129263