[PATCH] D129263: Windows packaging script. Check administrator permissions and/or 7-Zip version.

Carlos Alberto Enciso via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 8 02:30:11 PDT 2022


CarlosAlbertoEnciso added inline comments.


================
Comment at: llvm/utils/release/build_llvm_release.bat:24
+if not "%version%"=="" (
+  if not exist %SYSTEMROOT%\SYSTEM32\WDI\LOGFILES (
+    echo.
----------------
thieta wrote:
> Took me a while to understand this check - I am guessing you would only have permissions to see it if you are admin? Maybe that should be a comment to explain. There is no better way to test for admin rights in bat?
Another way to test for administrator rights is using the `mklink` command. From my understanding, it requires elevated permissions:
```
mklink /D link target
```




CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129263/new/

https://reviews.llvm.org/D129263



More information about the llvm-commits mailing list