[PATCH] D129263: Windows packaging script. Check administrator permissions and/or 7-Zip version.

Carlos Alberto Enciso via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 7 22:03:28 PDT 2022


CarlosAlbertoEnciso updated this revision to Diff 443138.
CarlosAlbertoEnciso added a comment.

Address feedback from @hans

- Better description for the reason to create symlinks.
- Expand regular expression to include versions 21 up to 29.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129263/new/

https://reviews.llvm.org/D129263

Files:
  llvm/utils/release/build_llvm_release.bat


Index: llvm/utils/release/build_llvm_release.bat
===================================================================
--- llvm/utils/release/build_llvm_release.bat
+++ llvm/utils/release/build_llvm_release.bat
@@ -14,6 +14,21 @@
 echo.
 exit /b
 
+REM Note:
+REM   7zip versions 21.x and higher will try to extract the symlinks in
+REM   llvm's git archive, which requires running as administrator.
+
+REM Check for correct 7-zip version and/or administrator permissions.
+for /f "delims=" %%i in ('7z.exe ^| findstr /r "2[1-9]"') do set version=%%i
+if not "%version%"=="" (
+  if not exist %SYSTEMROOT%\SYSTEM32\WDI\LOGFILES (
+    echo.
+    echo Script requires administrator permissions, or a 7-zip version 20.x or older.
+    echo Current version is "%version%"
+    exit /b
+  )
+)
+
 :begin
 
 REM Prerequisites:


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D129263.443138.patch
Type: text/x-patch
Size: 841 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220708/d784f477/attachment.bin>


More information about the llvm-commits mailing list