[PATCH] D128642: [AArch64][SVE] Use SVE for VLS fcopysign for wide vectors

David Truby via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 4 05:24:09 PDT 2022


DavidTruby added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:7661
+    VT = Op.getValueType();
+    IntVT = VT.changeTypeToInteger();
+    BSP = convertFromScalableVector(DAG, IntVT, BSP);
----------------
peterwaller-arm wrote:
> Is this line necessary or could it be pushed up? At a glance it appears it should already be an integer VT derived from VT. Same question for the VT assignment.
>From 7593-4: VT and IntVT will be scalable containers for the fixed length vector types. Here we need to get the original VTs back.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128642/new/

https://reviews.llvm.org/D128642



More information about the llvm-commits mailing list