[PATCH] D129003: [WPD] Filter out intrinsics inserted from whole-program-vtables

[Rong Xu via llvm-commits]

On Fri, Jul 1, 2022 at 10:01 AM Arthur Eubanks via Phabricator <
reviews at reviews.llvm.org> wrote:

> aeubanks added a comment.
>
> this doesn't seem very principled, it's seemingly adding checks in random
> places hoping that passes won't look too much at assumes/type tests
> is there anything wrong with making the instrumented build use
> -fwhole-program-vtables?
>
These instructions are like annotations. I don't think they should count as
real instructions in the heuristics.
I agree that we might need a better interface. But I do think they need to
be handled differently.

-fwhole-pgoram-vtables needs lto. we don't want to build
instrumentation binary with lto.

>
>
>
> ================
> Comment at: llvm/test/Transforms/InstCombine/wpvt.ll:1
> +; RUN: opt < %s -passes=instcombine -S | FileCheck %s
> +target triple = "x86_64-grtev4-linux-gnu"
> ----------------
> this test is very noisy and doesn't really show what's going on, could you
> reduce it a bit, and also maybe run it through `-passes=metarenamer` (and
> maybe convert to opaque pointers to remove some unnecessary pointer
> bitcasts via `opt -S -opaque-pointers foo.ll`)
>
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D129003/new/
>
> https://reviews.llvm.org/D129003
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220702/b74d6f72/attachment.html>