[PATCH] D129003: [WPD] Filter out intrinsics inserted from whole-program-vtables

David Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 1 10:13:52 PDT 2022


davidxl added a comment.

In the summary, do you mean 'should not be counted'?   Also agree that the test should be cleaned up.



================
Comment at: llvm/lib/Analysis/Loads.cpp:619
                                       ScanBB->rend())) {
-    if (Inst.isDebugOrPseudoInst())
+    if (Inst.isDebugOrPseudoInst() || Inst.isWholeProgramVTIntrinsic())
       continue;
----------------
Add a wrapper interface 'isNopInst()' instead?

These instructions should not be counted in inline size estimation either.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129003/new/

https://reviews.llvm.org/D129003



More information about the llvm-commits mailing list