[PATCH] D129003: [WPD] Filter out intrinsics inserted from whole-program-vtables

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added a comment.

this doesn't seem very principled, it's seemingly adding checks in random places hoping that passes won't look too much at assumes/type tests
is there anything wrong with making the instrumented build use -fwhole-program-vtables?



================
Comment at: llvm/test/Transforms/InstCombine/wpvt.ll:1
+; RUN: opt < %s -passes=instcombine -S | FileCheck %s
+target triple = "x86_64-grtev4-linux-gnu"
----------------
this test is very noisy and doesn't really show what's going on, could you reduce it a bit, and also maybe run it through `-passes=metarenamer` (and maybe convert to opaque pointers to remove some unnecessary pointer bitcasts via `opt -S -opaque-pointers foo.ll`)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129003/new/

https://reviews.llvm.org/D129003