[PATCH] D118302: [Spill2Reg][5/9] Code generation part 2.

[Vasileios Porpodas via Phabricator via llvm-commits]

vporpo added inline comments.


================
Comment at: llvm/test/CodeGen/X86/spill2reg_simple_2.mir:2
+# NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py
+# RUN: llc %s -o - -mtriple=x86_64-unknown-linux -enable-spill2reg -mattr=+sse4.1 --run-pass=spill2reg -simplify-mir -spill2reg-mem-instrs=0 -spill2reg-vec-instrs=99999 | FileCheck %s
+
----------------
Carrot wrote:
> All test cases have the option -spill2reg-mem-instrs=0. It looks to me more like a debug purpose option. A more practical and positive performance impact value should be larger than 0. Could you add a test case for it.
Yeah this is basically disabling the heuristic so that we can check the functionality even in small tests.
I am actually including some end-to-end tests with -spill2reg-mem-instrs set to default in the followup patch (https://reviews.llvm.org/D118303). But yes, I agree, I should add one more test here to exercise this option.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118302/new/

https://reviews.llvm.org/D118302