[PATCH] D129003: [WPD] Filter out intrinsics inserted from whole-program-vtables

[Arthur Eubanks via Phabricator via llvm-commits]

aeubanks added inline comments.


================
Comment at: llvm/lib/Analysis/Loads.cpp:619
                                       ScanBB->rend())) {
-    if (Inst.isDebugOrPseudoInst())
+    if (Inst.isDebugOrPseudoInst() || Inst.isWholeProgramVTIntrinsic())
       continue;
----------------
davidxl wrote:
> Add a wrapper interface 'isNopInst()' instead?
> 
> These instructions should not be counted in inline size estimation either.
the assume and type test should be already handled in `CallAnalyzer::analyzeBlock` by being ephemeral values (analyzed by AssumptionCache/`CodeMetrics::collectEphemeralValues`), but it'd be good to double check


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129003/new/

https://reviews.llvm.org/D129003