[PATCH] D128631: [AArch64] Initial sched model for Neoverse N2

[KAWASHIMA Takahiro via Phabricator via llvm-commits]

kawashima-fj added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64SchedA64FX.td:21
   let PostRAScheduler       =   1; // Using PostRA sched.
-  let CompleteModel         =   1;
+  let CompleteModel         =   0;
 
----------------
c-rhodes wrote:
> Matt wrote:
> > Is the change to CompleteModel intentional in this patch?
> > Is the change to CompleteModel intentional in this patch?
> 
> It is, thanks for pointing it out my intention was to notify Fujitsu engineers when I put the patch up, but I completely forgot.
> 
> @kawashima-fj @yutsumi 
> 
> The A64FX model is missing info for FTSSEL, FMSB, PFIRST. Also, RDFFR info is set on the pseudo and not the real instruction.
> 
> I suspect there's a bug in the scheduling code somewhere since the model was marked as complete, yet these missing instructions weren't detected
> until I added them for this model. I can't add the missing info for your model so I've just set it to incomplete, but thought I'd let you know.
> The A64FX model is missing info for FTSSEL, FMSB, PFIRST. Also, RDFFR info is set on the pseudo and not the real instruction.

@c-rhodes  Thanks for notifying me. We Fujitsu will address them and then revert `CompleteModel` to 1 shortly.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D128631/new/

https://reviews.llvm.org/D128631