[PATCH] D127965: [VPlan] Move recipe implementations to separate file (NFC).

Mon Jun 27 06:14:55 PDT 2022

fhahn marked an inline comment as done.
fhahn added inline comments.

================
Comment at: llvm/lib/Transforms/Vectorize/VPlanRecipes.cpp:523
+
+void VPWidenPHIRecipe::print(raw_ostream &O, const Twine &Indent,
+                             VPSlotTracker &SlotTracker) const {
----------------
Ayal wrote:
> While we're here, and considering additional execute()'s are expected to land here soon: it makes sense to have all methods of a recipe together, including its #if'd print(), and to fuse adjacent #endif/#if pairs of recipes that have only print() defined here. But VPWidenPHIRecipe and VPWidenPointerInductionRecipe have their print() amongst other print()'s and their execute() elsewhere in the file. Would be good to keep the above rules for consistency, or have all print()'s under one #if/#endif given that they look-alike.
I think it would probably be best to keep definitions for a single recipe next to each other. I moved the ::print functions!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127965/new/

https://reviews.llvm.org/D127965