[PATCH] D127965: [VPlan] Move recipe implementations to separate file (NFC).

Ayal Zaks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jun 27 09:55:56 PDT 2022


Ayal accepted this revision.
Ayal added a comment.
This revision is now accepted and ready to land.

In D127965#3612002 <https://reviews.llvm.org/D127965#3612002>, @fhahn wrote:

> Address latest comments, thanks!
>
>> Nice move! Would it be reasonable to also have a matching VPlanRecipes.h, excluding VPRecipeBase?
>
> I think this would require a bit more surgery, as VPlan.h contains multiple function definitions that require the full definition of different recipes types. This could be resolved by moving them to VPlan.cpp, but I think that would be best done separately. Also, I think in most file we would have to include both headers in any case?

Yeah, not much to be gained in terms of reducing compilation time, just to keep things in natural order as much as reasonable.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D127965/new/

https://reviews.llvm.org/D127965



More information about the llvm-commits mailing list